Evan Rittenhouse

Results 85 comments of Evan Rittenhouse

Hey @ephys good news - I think I've solved the issue. I've opened a PR for this [here](https://github.com/sequelize/sequelize/pull/14277/commits). I am, however, getting an error in this test. Is this an...

@John6Connor I'll take this one. May ask you for some clarifications as I move forward.

@ephys Quick question as I move into this - I notice this seems to be using `sequelize-typescript`. Is that going to have an effect on the code, or should the...

@ephys Seems like I've found the problem, but I'm not sure how we want to solve it. In `bulkCreate`, we define a helper function called `recursiveBulkCreate` which walks down the...

@John6Connor Just to clarify, are you expecting that the `Players` query should include the same `updateOnDuplicate` options in that query? Or that the included model, `players`, should be added to...

@ephys Personally, I prefer design 1. I think it's cleaner to have `include`-specific options residing in the `include` object itself. IMO, it also players nicer with the current recursive structure...

@neersighted I can probably do this, though am new to Poetry so would need some guidance. What approach is preferable, munging the submodule URLs and adding recursive cloning, or simply...

@neersighted Do we still want to implement this, or would we rather just track the Dulwich PR mentioned above?

@neersighted can you please give some guidance on how to test this? The other submodule test simply checks to see if the submodule directory exists, which is simple enough. Given...