Evan Rittenhouse

icon indicating a website link www.linkedin.com/in/evanrittenhouse icon indicating an email [email protected]

icon company @cloudflare icon location Chicago, IL icon location Working @cloudflare on network protocols. I also think runtimes are pretty sick

Results 85 comments of Evan Rittenhouse

fix(mssql): return no result when limit is zero

LGTM, please just fix the failing tests :)

bulkInsert should return array

@ephys I can take this one. I see `mysql` is the marked DB type, but this should affect all of them, no?

bulkInsert should return array

@ephys sorry, got really busy with stuff and just starting to look into this. Unless I'm wrong, this just looks like changing the return value of `bulkInsert` from `results[0]` to...

bulkInsert should return array

@ephys Cool. Read through the PR you linked [here](https://github.com/sequelize/sequelize/issues/14325#issuecomment-1089276253), and I don't necessarily see a reason for the returned array to include the number of rows affected. As far as...

bulkInsert should return array

@ephys I'm a little confused on the example given above. I don't see this behavior with SQLite tests, so I don't think it happens on all databases. Before installing MySQL...

bulkInsert should return array

@ephys It looks like this behavior actually differs between dialects. [Here](https://github.com/sequelize/sequelize/blob/9950b4bee896e9b50f6752be2767e28c9ba84a12/src/dialects/abstract/query.js#L83), the insert ID field is `insertId`. In SQLite, though, there's a different insert ID - `lastInsertID`. These return two...

Remove `Lib/test/` and `Lib/ensurepip` from `freeze-stdlib`

@youknowone How difficult do you think this would be?

`code.co_names` leaks a `__doc__` entry

@DimitrisJim how difficult do you think this would be?

`code.co_names` leaks a `__doc__` entry

Sure! I'd love to get onto the compiler side. Do you have a recommendation for where I should look?

Certain orange shades aren't appearing properly

So this is what it looks like with the Rust Treesitter parser installed (previously, I don't think it was. Still some weird highlight colors, specifically parameter names, macros, and crates)....