Euler Taveira

Results 103 comments of Euler Taveira

The JSON spec says nothing about this. The exact number representation is the one provided by Postgres. You didn't show the data types here but I bet that column "f_numeric"...

I don't follow. You asked a question about `pgindent`. AFAICS you didn't post another update solving all concerns. I suggest that you read [Creating Clean Patches](https://wiki.postgresql.org/wiki/Creating_Clean_Patches) and [Development Tools and...

If it is changing a lot, don't run it. Instead, fix some superfluous changes (such as whitespace and new line additions). I can clean it up later, if required.

I tried the following example: ```sql CREATE TABLE xyz ( a integer, b hstore, c jsonb, primary key(a) ); INSERT INTO xyz (a, b, c) VALUES(1, 'a=>x, b=>y'::hstore, '{"name":"account_no_history","value":"[{"acc":"3597","createdby":"Viztek,Pacs","createddt":"2015-09-24T17:14:30.728Z"}]"}'::jsonb); ```...

Could you elaborate the use case? If this feature is related to UPDATE, the columns that was not informed will stay as is, hence, wal2json don't need to mention them....

I tried to explain when old tuple is available [here](https://github.com/eulerto/wal2json/blob/master/wal2json.c#L1799). Maybe it would be a good idea to clarify this behavior in the README. If I were to write this...

@addisonj You submitted two features and it should be two pull requests or at least two commits. I saw that you change some unrelated lines, fix them. I can see...

No, it doesn't. ``` euler=# SELECT 'init' FROM pg_create_logical_replication_slot('test_slot', 'wal2json'); ?column? ---------- init (1 registro) euler=# begin; BEGIN euler=# commit; COMMIT euler=# SELECT data FROM pg_logical_slot_get_changes('test_slot', NULL, NULL, 'pretty-print', '1');...

@qweeze this PR is incomplete. It should be implemented in both format. @bahaa do you want to update this PR? Also, use a single commit.