wal2json icon indicating copy to clipboard operation
wal2json copied to clipboard

Published 20 hours ago • verified publisher icon eulerto

feat: Adds 'skip-empty-xacts' support

Open adrijshikhar opened this issue 1 year ago • 6 comments

fixes #106

adrijshikhar avatar Aug 02 '22 16:08 adrijshikhar

@eulerto Please have a look and let me know what changes are required

adrijshikhar avatar Aug 09 '22 06:08 adrijshikhar

@eulerto can you please go through the comments I posted? Thanks

adrijshikhar avatar Sep 19 '22 15:09 adrijshikhar

I don't follow. You asked a question about pgindent. AFAICS you didn't post another update solving all concerns. I suggest that you read Creating Clean Patches and Development Tools and Help (there is a subsection called What's the formatting style used in PostgreSQL source code?.

eulerto avatar Sep 20 '22 13:09 eulerto

thanks I will go through that. I have addressed all of your comments and made changes accordingly. I am stuck on pgindent. Somehow it changes all of the indentations. I will try to fix it and then update you.

adrijshikhar avatar Sep 22 '22 17:09 adrijshikhar

If it is changing a lot, don't run it. Instead, fix some superfluous changes (such as whitespace and new line additions). I can clean it up later, if required.

eulerto avatar Sep 22 '22 17:09 eulerto

yeah sure thanks

adrijshikhar avatar Sep 29 '22 13:09 adrijshikhar