wal2json icon indicating copy to clipboard operation
wal2json copied to clipboard

Resolves #106: Implementing `skip-empty-xacts`.

Open bahaa opened this issue 5 years ago • 15 comments

Adding new parameter skip-empty-xacts. I chose the same parameter name as Postgres' test_decoding.

This should resolve #106.

bahaa avatar Jun 28 '19 12:06 bahaa

What is the reasoning behind not defaulting this to true?

joekohlsdorf avatar Aug 02 '19 16:08 joekohlsdorf

@joekohlsdorf backward compatibility. I think the plugin should behave the same for current users. Current users already get empty transactions and I think they are dealing with them already.

bahaa avatar Aug 02 '19 22:08 bahaa

In this particular case I would argue that the users aren't doing anything with empty transactions. So there is nothing lost by removing them because they contain no information at all. They are just wasting network bandwidth and CPU cycles, depending on the use case this can require a substantial amount of additional processing.

joekohlsdorf avatar Aug 13 '19 12:08 joekohlsdorf

Any chance of merging this PR?

qweeze avatar Feb 08 '20 22:02 qweeze

@qweeze this PR is incomplete. It should be implemented in both format. @bahaa do you want to update this PR? Also, use a single commit.

eulerto avatar Feb 10 '20 13:02 eulerto

@eulerto sure. I can update it on the weekend. What do you mean by "both formats"?

bahaa avatar Feb 10 '20 15:02 bahaa

@bahaa: there's an option format-version which can be either 1 or 2 (see README) -- anything new needs to support both versions.

jmealo avatar Mar 31 '20 00:03 jmealo

@jmealo Thank you. I forked my version before there was support for two formats. I'll try to fix it this weekend.

bahaa avatar Mar 31 '20 08:03 bahaa

Looking forward to getting this feature. @bahaa any update on this? Thanks

ajitj avatar Oct 25 '20 15:10 ajitj

@bahaa would be great to get this merged

llehtinen avatar Apr 01 '21 12:04 llehtinen

@bahaa pls merge this.

jehanzebqayyum avatar Sep 21 '21 12:09 jehanzebqayyum

@bahaa if you are unable to work on this, I will be more than happy to take it further.

adrijshikhar avatar Jun 15 '22 07:06 adrijshikhar

@adrijshikhar sure. I'd be so glad if you do.

bahaa avatar Jun 15 '22 10:06 bahaa

sure i will pick this up

adrijshikhar avatar Jul 27 '22 09:07 adrijshikhar

#248

adrijshikhar avatar Aug 02 '22 16:08 adrijshikhar