wal2json
wal2json copied to clipboard
Resolves #106: Implementing `skip-empty-xacts`.
Adding new parameter skip-empty-xacts
. I chose the same parameter name as Postgres' test_decoding
.
This should resolve #106.
What is the reasoning behind not defaulting this to true
?
@joekohlsdorf backward compatibility. I think the plugin should behave the same for current users. Current users already get empty transactions and I think they are dealing with them already.
In this particular case I would argue that the users aren't doing anything with empty transactions. So there is nothing lost by removing them because they contain no information at all. They are just wasting network bandwidth and CPU cycles, depending on the use case this can require a substantial amount of additional processing.
Any chance of merging this PR?
@qweeze this PR is incomplete. It should be implemented in both format. @bahaa do you want to update this PR? Also, use a single commit.
@eulerto sure. I can update it on the weekend. What do you mean by "both formats"?
@bahaa: there's an option format-version
which can be either 1 or 2 (see README) -- anything new needs to support both versions.
@jmealo Thank you. I forked my version before there was support for two formats. I'll try to fix it this weekend.
Looking forward to getting this feature. @bahaa any update on this? Thanks
@bahaa would be great to get this merged
@bahaa pls merge this.
@bahaa if you are unable to work on this, I will be more than happy to take it further.
@adrijshikhar sure. I'd be so glad if you do.
sure i will pick this up
#248