Edward Thomson comments

Results 545 comments of


                                            Edward Thomson

Use `if: success() || failure()` instead of `if: always()`?

Oh oops, I realize now that I parsed this precisely backwards. Thanks for the explanation.

Patch parse fuzzer does not fuzz GIT_OID_SHA256 or prefix lengths other than zero

I'd certainly like to see more fuzzing; this isn't something that I'm going to tackle, personally, in the immediate future, so contributions are welcome here.

git_repository_open, given a nonexistent path, trashes `pthread_self` on macOS/ARM64

I'll take a look, but you *must* call `git_libgit2_init` before calling any other function. This sets up the thread-local storage that libgit2 uses for things like error handling. If `git_repository_open`...

git_repository_open, given a nonexistent path, trashes `pthread_self` on macOS/ARM64

It also seems like we should add some additional documentation to the primary entry points for the application, in the `git_repository` apis to point this out; clone, init and open...

git_repository_open, given a nonexistent path, trashes `pthread_self` on macOS/ARM64

Thanks for the update! I will leave this open so that I can: 1. Take another look at `git_libgit2_init`. It's a footgun that we need to improve. 2. Update the...