Edward Thomson comments

Results 549 comments of


                                            Edward Thomson

ssh: Omit port option from ssh command unless specified in remote url

Thanks for the fix! Great improvement.

SSH Custom Callbacks to allow support for ProxyCommand and SSH configs

Two things here: * libssh2 is... not a great dependency for us. With that in mind * This level of customization is why we allow custom ssh backends, IMO.

SSH Custom Callbacks to allow support for ProxyCommand and SSH configs

I was closing PRs as a sort of a scream test. Consider your scream heard. 😁 I don't have any interest in dropping support for libssh2. I don't _love_ libssh2,...

SSH Custom Callbacks to allow support for ProxyCommand and SSH configs

Thanks for the details; we should figure this out then.

Add an equivalent of `git remote set-head`.

Indeed; I think that we should expose this. Seems like a reasonable feature. I'd be happy to review a PR.

Document function parameters direction

Hey @anatol - what a timely coincidence. I’ve been working on a header parser to update our documentation site and potentially for the .NET bindings as well. I’m intending to...

Document function parameters direction

I've made a lot of improvements here in https://github.com/libgit2/libgit2/pull/6949 - there are surely still further improvements, but this is a good start, IMO.

Add SecCopyErrorMessageString for iOS and update README for iOS

> I suggest for now we just skip the tests on iOS and add them back later. 👍 Thanks; I want to figure out how this integrates with #6848 since...

Add SecCopyErrorMessageString for iOS and update README for iOS

Thanks! I moved the iOS build into the nightlies, and I reverted the clar changes so that we could think a bit more how (or if) we would address iOS...

Disagreement between `git_message_trailers` and `git-rev-list --format=%(trailers)`

Thanks for the report; we should indeed take a look at this.