Edward Thomson

icon indicating a website link http://www.edwardthomson.com/

icon company Stacklok icon location Cambridge, UK icon location Product at @Stacklok; maintainer of @libgit2. Formerly product and engineering at @Vercel, @GitHub, @Microsoft.

Results 549 comments of Edward Thomson

Leak in git_odb_backend_one_pack/git_odb_add_backend + new API request

Thanks; indeed we should give you a mechanism to free our backends. I agree that I'm surprised that you're hitting any failures here, though. I know it's been a while...

Leak in git_odb_backend_one_pack/git_odb_add_backend + new API request

Thanks for the details; I'll leave this open because I do want to fix this. 1. The libgit2 philosophy is (or perhaps _was_) - if an allocation error occurs, we...

sharedRepository config option not honored

This feels like a great place for a new contributor to jump in so I added some labels to encourage that. 😁

Git clone causes an "SSL error: syscall failure:" with a specific repo

> This is extremely difficult to reproduce. I don't even know what it is about this specific repo that is causing the problem as other, repos owned by the same...

Git clone causes an "SSL error: syscall failure:" with a specific repo

Hi @MattGal - do you have any more details offhand? Is it always the same repo or different repos? Has it ever happened with a public repo or always private?...

Handle cases where content length of an http response is zero

Hey @lrm29 - curious if this is ready for review? Is there anything that I can help with?

Handle cases where content length of an http response is zero

Thanks! Wanted to check in because I've been ignoring it since it was marked as draft but it also looks correct and complete. I'll pull it in to a v1.9.1.

submodule: git_index_add_bypath does not move conflict entries to REUC for submodules

Yes, I believe so, too.

"LibGit2Sharp.LibGit2SharpException: could not initialize security context" while cloning

What are you trying to clone from? GitHub.com? GHES? On prem azure devops? Hosted Azure DevOps? Something else? Does it have a valid SSL cert or is it self signed?...

"LibGit2Sharp.LibGit2SharpException: could not initialize security context" while cloning

@happy2ganesh Same questions if you can help: What are you trying to clone from? GitHub.com? GHES? On prem azure devops? Hosted Azure DevOps? Something else? Does it have a valid...