Edward Thomson
Edward Thomson
Thanks for the PR 👀
I made a few minor changes - I wanted to make sure that we supported FIPS mode on SHA1 as well, to ensure that we had more test coverage. Doing...
If you wouldn't mind taking a look at your leisure to make sure that everything makes sense. 🙏
Great; thanks again!
It does matter; we need to clear it *before* the write callback. If it's null, the write callback will not try to calculate the hash, it will just do the...
Happily, it was a very good question that should have been better explained in the code, commit message, or PR.
@Therzok Does libgit2 changing that interface affect our public API? (In a lot of cases our higher level API provides a buffer for such fallout.) Great to know either way....
I admit that it will (or, I guess depending on how well thought out 1.0 is, _may_) become burdensome to keep the old interfaces around. I can only think of...
> There will still be cases where we can't provide backwards compatibility, so stabilizing of LibGit2Sharp is at least partially dependent on a 1.0 of libgit2. Maybe? In the example...
> So my advice would be to bump the major version with reckless abandon - because that's how it should be! If you're changing the public API surface - and...