Esteve Fernandez
Esteve Fernandez
@youtalk should the packages that have a `tier4` prefix also have an `autoware` prefix? Or should they be renamed to only have `autoware` as their prefix?
All the packages that didn't have a prefix (either `tier4` or `autoware`) have been renamed or are in review. I haven't submitted PRs to rename rviz plugins because we're moving...
Here's the list of plugins that the https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/rviz/autoware.rviz file uses: - AutowareDateTimePanel - autoware_mission_details_overlay_rviz_plugin/MissionDetailsDisplay - autoware_overlay_rviz_plugin/SignalDisplay - autoware_perception_rviz_plugin/DetectedObjects - autoware_perception_rviz_plugin/PredictedObjects - autoware_perception_rviz_plugin/TrackedObjects - rviz_common/Displays - rviz_common/Group - rviz_common/Selection - rviz_common/Tool...
@xmfcx thanks, I only checked the packages that implement those plugins, but not the packages that depend on them yet. In any case, I'm sorry but I don't understand why...
I like option 1 too, in my opinion `common` should be as small as possible and aim for keep packages in folders that are more descriptive.
@SakodaShintaro I've submitted https://github.com/autowarefoundation/autoware_tools/pull/110, it should be merged after this PR is merged.
@mitsudome-r @xmfcx I've fixed the conflicts again, could you approve this PR when you can? Thanks
@vividf fixed. It'd be nice to get a review from the other code owners, this PR was originially submitted almost a month ago, so it'll probably get conflicts again.
@xmfcx do you have a moment to review this? Thanks.
@kosuke55 thanks for the fixes :bowing_man: I've rebased this PR on top of `main` and fixed the conflicts.