Enrico Stahn
Enrico Stahn
It appears like I made provisions for this use-case back in the day but didn't actually implement it: https://github.com/estahn/k8s-image-swapper/blob/a6bf66791ed59e3f595b8d4f83c61ac0fb5d2e64/.k8s-image-swapper.yml#L45-L48 https://github.com/estahn/k8s-image-swapper/blob/a6bf66791ed59e3f595b8d4f83c61ac0fb5d2e64/pkg/registry/ecr.go#L49-L53 Do you think you can adjust the changes to use...
Looking good so far. Will give it another review a bit later or tomorrow morning.
:tada: This PR is included in version 1.4.0 :tada: The release is available on [GitHub release](https://github.com/estahn/k8s-image-swapper/releases/tag/v1.4.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:
Not sure why this was never merged. Seems to be obsolete now. Thanks for the contribution, much appreciated.
Hi @JonathanLachapelle , Revisiting reported issues. Is this still something you're having issues with?
From practical experience this does not appear to be an issue. If so, I will reopen it.
@Jasper-Ben Thanks for investigating this. We could possibly use https://github.com/dyson/certman to circumvent this issue. If you have time to contribute that would be amazing, otherwise, I will see if I...
@Jasper-Ben Fair enough. This is related and can probably used as guidance: https://github.com/golang/go/issues/38877#issuecomment-626906346
Could this have an adverse effect on pytest/moto, e.g. some tests are mocked, some not - which results in all tests sharing the same session/client?
I'm facing a similar issue. Would be great if there is no draft created if there are no changes. I'm using `publish: true` and it started to create empty releases....