Enrico Stahn

Results 139 comments of Enrico Stahn

@haghabozorgi Are you still having this issue? Can you export the k8s-image-swapper configmap and add it?

@cuppett Thanks for your submission. The only concern would be if this breaks the release process, but I can deal with this down the line. Always good to simplify things....

@cuppett Apologies, there was an issue with the CI pipeline not testing the code correctly. I reverted your PR as it breaks the release and image scan actions.

We're using goreleaser for the release process. The CI step uses `goreleaser release --rm-dist --snapshot` to build an image that can be checked for security vulnerabilities. This step fails with...

@J5lx Great question. To be frank I have not tested the config file part and just assumed cobra (the library we use) is dealing with it. I will investigate this...

> Now that #124 is merged, would you accept a PR for this issue? @matejzero Yes, would be great if you can work on this. Otherwise, I may have a...

@matejzero I suggest counting the values within the loop you linked above and then add then below that loop. There is already a function doing the counting: [CountProcessState](https://github.com/hipages/php-fpm_exporter/blame/1181deb197819a570e295890ec817b5823e37a27/phpfpm/exporter.go#L190) > At...

@matejzero Thanks, I will have a look later today. Do you mind if I'm changing it to be more inline with how I would implement it?

@szokeptr We had similar issues and ended up having enough headroom to scale before reaching 100%. The problem is PHP-FPM doesn't have a dedicated thread for returning metrics (`/status`). It's...

@lazychanger Can you provide more details on this?