k8s-image-swapper icon indicating copy to clipboard operation
k8s-image-swapper copied to clipboard

Published 20 hours ago • verified publisher icon estahn

feat: add custom tags for ECR object

Open darkweaver87 opened this issue 2 years ago • 2 comments

This PR adds the ability to configure custom tags for created repositories.

darkweaver87 avatar May 03 '22 12:05 darkweaver87

Codecov Report

Base: 59.87% // Head: 59.87% // No change to project coverage :thumbsup:

Coverage data is based on head (3bbc710) compared to base (6eacc50). Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   59.87%   59.87%           
=======================================
  Files           5        5           
  Lines         314      314           
=======================================
  Hits          188      188           
  Misses        103      103           
  Partials       23       23
Impacted Files Coverage Δ
pkg/config/config.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 04 '22 09:05 codecov[bot]

Hi @estahn,

Your requested change was made. Are we good ?

mloiseleur avatar Jun 01 '22 07:06 mloiseleur

@estahn is something missing here?

project0 avatar Nov 18 '22 10:11 project0

Thanks for the review :-)

darkweaver87 avatar Dec 15 '22 09:12 darkweaver87

It appears like I made provisions for this use-case back in the day but didn't actually implement it:

https://github.com/estahn/k8s-image-swapper/blob/a6bf66791ed59e3f595b8d4f83c61ac0fb5d2e64/.k8s-image-swapper.yml#L45-L48

https://github.com/estahn/k8s-image-swapper/blob/a6bf66791ed59e3f595b8d4f83c61ac0fb5d2e64/pkg/registry/ecr.go#L49-L53

Do you think you can adjust the changes to use the configuration from target.aws.ecrOptions.tags instead?

estahn avatar Dec 15 '22 09:12 estahn

Is it ok this way ?

darkweaver87 avatar Dec 15 '22 13:12 darkweaver87

Looking good so far. Will give it another review a bit later or tomorrow morning.

estahn avatar Dec 15 '22 14:12 estahn

All done :-)

darkweaver87 avatar Dec 16 '22 08:12 darkweaver87

:tada: This PR is included in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

estahn avatar Jan 01 '23 00:01 estahn