Elliott Sprehn
Elliott Sprehn
Rietveld also thinks that diff is invalid. Weird. https://codereview.chromium.org/558163004/diff/40001/LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash.html
This is really hard to fix because the syntax highlighting is done on the client, and we often don't have the context to know what state to start highlighting in....
Yeah I can resyntax highlight when context is loaded. Note that another way to fix this would be to expose the base files from the server, or the hash/rev of...
Really need to get a better API from rietveld, parsing it's side by side diff into the unified diff is buggy.
It shouldn't show you the UI to send a message, was this with the "m" key?
I'll have to think about this, it's unfortunately not easy since it requires loading sections of the file that are not in the diff.
I'll have to think about how to do this, the old inbox view was far too cluttered and not useful.
I hate that hover thing in crbug, it's really annoying. I really wish there was an API so I could show a more minimal UI, but I suppose I could...
These all sound like great ideas, but it needs server side support so it probably won't happen soon.
This requires a better API from rietveld. How did you end up without a base file?