Elliott Sprehn
Elliott Sprehn
They are when you're in the commit queue, maybe we can always show them for the latest patch set.
Yeah, that's on the roadmap, Ojan really wants it too. Unfortunately it's a lot of effort so it probably won't be for a while.
I'll have to think about this. I fear having tons of buttons in every dialog.
What do you expect j/k to do?
I added the <cr-keyboard> widget in https://github.com/esprehn/chromium-codereview/commit/37ce43da35733125e4870d1378966c041eb168b6 so this should just be a matter of hooking up the keys to things.
I'll have to think about how to make that work with the dialog. HTML5 <dialog> is always fixed at the top of the screen so bringing it up would jump...
ojan@ Ah yeah I see is vertically centered, I just set top: 100px long ago in the CSS since the center looked kind of silly for some small dialogs. I...
How do you expect j/k to work when multiple patchsets are expanded?
We have the same problem in cloud functions. The cloud function reacts to the client doing something and needs to log an event to analytics on behalf of that user....
Having aria take precedence matches what we do for style ex. ```html #shadow-root :host { color: blue; } ``` This element is red, because we assume the consumer of the...