Edward Shogulin

Results 12 comments of Edward Shogulin

You implemented JIT emitter: good start, thanks! I would like to suggest next implementation steps. 1. Update tests to be sure that your implementation is used. Tests should fail: `acl_f32`...

You implemented JIT emitter: good start, thanks! But how did you test it? I would like to suggest next implementation steps. Explore existing PR from *Example Pull Requests* section here:...

> Hello, sir I do not understand the acl_f32 primitive is used. and also how should Finish JIT emitter Hi @Aryan8912, you can use `Sigmoid` implementation as example: https://github.com/openvinotoolkit/openvino/pull/23065. The...

> > Thanks, good start, there are minor comments. Don't forget about the tests, please. > > Thank you @eshoguli for the comments. I will make these changes. I had...

> Hey @eshoguli, I have incorporated the code review feedback and added the IsInf operation to the existing element-wise tests. However, when I run the command `./bin/arm64/Release/ov_cpu_func_tests --gtest_filter="*smoke*Eltwise*"`, 76 tests...

@awayzjj, thanks for contribution. Looks like you are close to finishing. Please, rebase onto the latest remote master. The branch has to be rebased before CI builds will be started.

Tested on commit: ``` commit c5dd7753d0475ffec0f192f3181fe67a1d761680 (tag: v24.07, origin/main, origin/HEAD, main) Author: Jenkins Date: Fri Jul 26 12:07:30 2024 +0000 Compute Library v24.07 ``` **How to easilly reproduce** branch: [es/aarch64/neon_gemm_u8i8_support/](...

Validated: case with `QASYMM8` + `QASYMM8_SIGNED` inputs and `F32` output is supported https://review.mlplatform.org/ml/ComputeLibrary, thanks! Note, please, the fix has not yet been applied in https://github.com/ARM-software/ComputeLibrary

you can use eshoguli:es/neon_gemm_s8s8s32_perf_default branch to easily reproduce the issue