openvino icon indicating copy to clipboard operation
openvino copied to clipboard
verified publisher icon openvinotoolkit

Aryan softplus

Open Aryan8912 opened this issue 1 year ago • 3 comments

close : https://github.com/openvinotoolkit/openvino/issues/24109

Aryan8912 avatar May 06 '24 09:05 Aryan8912

You implemented JIT emitter: good start, thanks! But how did you test it?

I would like to suggest next implementation steps. Explore existing PR from Example Pull Requests section here: https://github.com/openvinotoolkit/openvino/issues/24109, please.

  1. Update tests to be sure that your implementation is used. Tests should fail: acl_f32 primitive is used.
  2. Update JIT kernel. Tests should fail: expected and reference tensors comparation fails.
  3. Finish JIT emitter. Tests should pass.

Let me know if you still have any questions.

eshoguli avatar May 07 '24 10:05 eshoguli

Hello, sir I do not understand the acl_f32 primitive is used. and also how should Finish JIT emitter

Aryan8912 avatar May 12 '24 14:05 Aryan8912

Hello, sir I do not understand the acl_f32 primitive is used. and also how should Finish JIT emitter

Hi @Aryan8912, you can use Sigmoid implementation as example: https://github.com/openvinotoolkit/openvino/pull/23065. The line where Sigmoid is added in Executer: https://github.com/openvinotoolkit/openvino/pull/23065/files#diff-ce3f79fe72be04c8660d4f853b11227473660eb109c3fc984c6ff4d2b4d97738R32.

Don't ignore tests, please. Let me know if you still have any questions.

eshoguli avatar May 13 '24 09:05 eshoguli

hey @Aryan8912, will you have a time to finish this?

mlukasze avatar Jun 18 '24 09:06 mlukasze

This PR will be closed in a week because of 2 weeks of no activity.

github-actions[bot] avatar Jul 04 '24 00:07 github-actions[bot]