Eric Van Norman
Eric Van Norman
Still an issue: see https://prow.istio.io/job-history/gs/istio-prow/pr-logs/directory/unit-tests_istio from https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/36786/unit-tests_istio/1480908993751683072.
Still exists for the 1.14 branching.
Example: ``` - name: BUILD_WITH_CONTAINER value: "0" image: gcr.io/istio-testing/build-tools:release-1.16-6363b97c6bc60b7a3a8d52c5e08322d8394149e2 jobs: - command: - make - build env: - name: BUILD_WITH_CONTAINER value: "0" - name: BUILD_WITH_CONTAINER value: "0" image: gcr.io/istio-testing/build-tools:master-6363b97c6bc60b7a3a8d52c5e08322d8394149e2 ```...
You also see `BUILD_WITH_CONTAINER` appearing twice within a job.
Would still be good to get this done.
cc @istio/release-managers-1-10 This was one of the noted items during the branching.
Correct, adding the label there would apply to all repos, which we don't want. I believe we just need to create another cherry-picker for the istio.io repo only which adds...
I agree for nearly all repos, we do not want auto merge on cherry-picks for the reasons John stated. My original statement was that the behavior today is org wide,...
FYI: https://github.com/istio/istio.io/issues/6332
I added a remark in https://github.com/istio/istio.io/pull/11448 today, and the bot replied. Will be curious if the CP is created when the PR merges.