Eric Van Norman comments

Results 205 comments of


Eric Van Norman

add "app.kubernetes.io/name" to gateway.podlabels

/ok-to-test

add "app.kubernetes.io/name" to gateway.podlabels

I'll add a DNM which @costinm can remove after he reviews the additional changes.

ambient: rewrite controller using `krt`

LGTM but waiting on approval to make sure @dhawton agrees as well.

[release-1.18] Fix typo Authorizaion to Authorization

Noting that this will not get picked up in the docs if we do make the change unless we decide to rebuild all the 1.18 docs.

Regen API with new tools

I believe the common-files update also failed, so we cut add a `make update-common` in this PR or do in another PR.

add guidelines for adding new features to stable APIs

/test gencheck

Investigate if we can remove duplication of protos

Also see https://github.com/istio/istio.io/issues/14992. Today we have sync.sh which copies the bottom portion of the file from the older version, and sets mode:none on all the newer versions of the file....

Fix text indent

/ok-to-test

can we support "auto alphabetical order under" when add member in local ?

I don't think we want to have people enter their names in multiple places. This leads to potential issues with changes overriding others or changes being lost. Maybe you have...