test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard
verified publisher icon istio

Cherrypicker not picking up release-1.14 comments

Open craigbox opened this issue 3 years ago • 5 comments

Leaving a /cherrypick release-1.14 comment on istio/istio.io issues is not causing the bot to act. Setting the cherrypick/release-1.14 label does what we want.

  • Current example where commenting didn't do anything: https://github.com/istio/istio.io/pull/11380
  • Example of a failure where I later set the label and it worked: https://github.com/istio/istio.io/pull/11291
  • Example of where setting only the label worked: https://github.com/istio/istio.io/pull/11276

craigbox avatar Jun 10 '22 11:06 craigbox

possibly a separate issue, but on failed cherry-picks, I have observed two attempts being made at performing the cherry-pick and therefore 2 separate issues created for each attempt.

Example:

  • PR https://github.com/istio/istio/pull/39367
  • Issue 1: https://github.com/istio/istio/issues/39395
  • Issue 2: https://github.com/istio/istio/issues/39393

Appears to have created duplicates for 1.12, 1.13 and 1.14

GregHanson avatar Jun 10 '22 13:06 GregHanson

In case it's related to release-1.14 specifically, I tried adding cherrypick/master label on a PR to that branch, and nothing happened. https://github.com/istio/istio.io/pull/11395

craigbox avatar Jun 10 '22 17:06 craigbox

I tried both approaches in https://github.com/istio/istio.io/pull/11398 and 6 hours later there's no cherrypick.

craigbox avatar Jun 15 '22 15:06 craigbox

I added a remark in https://github.com/istio/istio.io/pull/11448 today, and the bot replied. Will be curious if the CP is created when the PR merges.

ericvn avatar Jun 16 '22 15:06 ericvn

https://github.com/istio/istio.io/pull/12273

Setting the cherrypick/release-1.16 tag doesn't seem to work properly

aimuz avatar Nov 22 '22 02:11 aimuz