Eric StJohn

Results 305 comments of Eric StJohn

Adding some detail about the failure. Seems this was deserializing a WeakReference object: ``` System.Resources.Extensions.Tests.FormattedObject.BasicObjectTests.BasicObjectsRoundTripAndMatch(value: WeakReference { IsAlive = True, Target = https://dot.net/, TrackResurrection = True }, _: [BinaryFormatTests.TypeSerializableValue, BinaryFormatTests.TypeSerializableValue])...

cc @viktorhofer - ApiCompat is for comparing libraries to ensure they are compatible with previous versions. It's meant to catch problems as they are introduced by API producers. It looks...

It seems like there would be a product bug if an EF package has a dependency on CodeAnalysis that is visible to ASP.NET Core. EF should just be referencing CodeAnalysis...

Is Microsoft.EntityFrameworkCore.Design meant to be used in a way that it brings CodeAnalysis along with it and is responsible for deploying it? That feels a bit unusual. Typically these sort...

> In typical applications `Microsoft.EntityFrameworkCore.Design` and `Microsoft.EntityFrameworkCore.Tools` should only be referenced as design-time dependencies. I'm not sure what that means. I see a mix a references that look an awful...

> We allow Microsoft.EntityFrameworkCore.Design to be referenced normally and deployed with the application if certain operations like migrations management need to be performed at runtime. I am just saying that's...

> What is the issue with the dependencies being present in the output directory if they aren't referenced from the app? You're taking on a very large dependency set that...

For the analyzers package you should upgrade and keep the dependency private. It's already that way. It doesn't leak to your users: https://github.com/dotnet/efcore/blob/f0965d6e88ac88ee235deef21804e64bbc62decf/src/EFCore.Analyzers/EFCore.Analyzers.csproj#L32-L33 For the designer package I do think...

> It's more sustainable for the transitive dependencies to be updated by the packages that directly depend on them. So here that would mean you'd need an update to `Microsoft.CodeAnalysis.Workspaces.MSBuild`...

This is the highest-hitting libraries known build issue. Worth a look if you can determine the cause. https://helix.dot.net/BuildAnalysis/KnownIssues @tannergooding @jeffhandley