Eric StJohn

Results 305 comments of Eric StJohn

Yes. - https://github.com/dotnet/corefx/blob/master/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj - https://devdiv.visualstudio.com/DevDiv/_git/DotNet-Trusted?path=%2Fsrc%2FAccessibility%2Fsrc%2FAccessibility.ilproj&version=GBmaster Both of those cases happen to use a different key so we don't hit this issue, but I noticed it with a test asset and...

If you're interested, Accessibility is a PIA and we build it this way because we don't have TLBImp for .netcore. It can't be defined in C# because it contains named...

> WriteMetadataConstant Possibly, but I don't expect folks would prefer that. Regardless I don't want to dig up those issues here. > I think it's ok to have the issue...

The IL is generated from the TLB then checked in, which is more reliable than a human trying to translate that to VB.

FYI I think this is needed for source build. /cc @chcosta

We determined that it is not required for source build, so it's no longer a dependency we need to drive for 3.0. I'd see this more as dogfooding / best-practice.

@jozkee actually it's likely caused by https://github.com/dotnet/runtime/commit/81f1f5ef694b62d801291fb70d86dd5ed9074448 I wonder if we should actually capture that `out bool createdNew` and only set the ACL on the mutex if it was just...

See https://github.com/dotnet/corefx/blob/49d249fa023e8575dba7e35febb4446e4fa13f98/eng/versioning.targets#L66 for how we do it in CoreFx.

Agreed that a single source file is simpler. Just wanted to share the corefx solution which was handling a more generic problem.

Singe instance of a failure, looks to me like test failed to missing counter installation: ``` Info: Successfully installed performance counters in C:\h\w\A4A0097E\t\pv4sxcea.r50\provider.man System.Diagnostics.Tests.PerformanceDataTests.PerformanceCounter_PerformanceData [SKIP] Condition(s) not met: "IsRunnableEnvironment" Info:...