Eric StJohn

Results 305 comments of Eric StJohn

Seems like StrongNamer should be able to rewrite the symbols too. This seems to be how the linker does it: https://github.com/dotnet/linker/blob/93de7209f008e297770e5b76ec43a84e7e88a131/src/linker/Linker.Steps/OutputStep.cs#L205-L223

I'm not sure if it's best for this issue or not, but the support table can be improved in more ways. Today it's completely calculated. Calculation is good since it...

Sure, I'll submit a change that does it.

I don't think we can excuse timeouts like this as a "Known Build Issue" because it could excuse a hang in the build itself. @dotnet/runtime-infrastructure I will close this issue....

@steveharter does your theory imply a regression or an existing issue in either DI or reflection?

We are on the Preview6 SDK in main now for 2 weeks: https://github.com/dotnet/runtime/commit/4a8aca8bc748888423686beeccd233ee2f6a9f76 I do see some folks still hitting this on preview6 https://dev.azure.com/dnceng-public/public/_build/results?buildId=767175&view=logs&j=f979b8ec-ebd4-511f-1076-61f8eccd76f8&t=4539cfc2-b7a3-5dcb-c27b-36c97fdb9947&l=5649 I see @steveharter's change https://github.com/dotnet/runtime/commit/670d11f4d30d16153a3f5a667b1bb5b5ced9e0c9 only...

It was moved into future because at the time it had 0 recent hit counts. Odd that there have been new hits mentioned here, but no updates to the count...

Can you point to where that's failing in the `runtime` pipeline? I don't see any failures there -- that was my point in triaging this out. We aren't hitting any...

Backporting to 9.0 as well https://github.com/dotnet/runtime/pull/107109