Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
I can update the version in this PR but I have no permissions in this repository to merge or publish. I originally thought the deprecation would at least include bug...
> so Im sorry but it wont be merged. will it not be merged because of size increase or because of missing tests? Because I can add a test that...
Just checked: The size diff is because `.size-snapshot` is outdated on master. If it would be up-to-date then this PR wouldn't affect it.
> When removeOnDirtyLabel removes the label it doesnt add the label back when the conflicts are resolved. You're saying it doesn't add `removeOnDirtyLabel` when conflicts are resolved? This sounds like...
Ah now I remember. I think this was intended since the label that's removed could be something like "ready to merge". And rebase after review kind of invalidates that. But...
I suspect that's very hard to do since that would introduce statefulnes into the action. Have you checked if there are existing patterns that can throttle entire runs instead if...
If you already throttle the action what would be achieved if the action itself throttles? I don't see how the action could throttle that couldn't be achieved at the workflow...
It used to be that forks only get a read-only token. Is that no longer the case? If forks still get a read-only token, a missing token would be a...
> This is most possibly just a temporary issue; How would I know that? Implementing back-off logic for rare, one-off issues sounds like a lot of work for little gain....
> Plain comments work pretty well IMO: [pypa/pip#8086 (comment)](https://github.com/pypa/pip/pull/8086#issuecomment-625487715) I prefer using PRs for discussion. Comments from bots make the conversation hard to read which is why I try to...