Andrew James

Can you please rewrite the history to squash related commits and put the clang-tidy changes first? Having 14 commits with very similar names doing partial applications of a change makes...

Did you have a cursed item equipped or in your inventory? https://github.com/diasurgical/devilutionX/issues/4575 will be fixed when the 1.4.1 release comes out and may be the cause of this one.

Looking at this there is one relatively simple change that could be made, moving the `if (numpremium < maxItems) {...}` block below the while loop lets the loop shift empty...

welp :D Also turns out it builds without this include after installing xcode extras, must've been using an outdated toolchain previously... probably still worth it given the use of that...

> Not sure why tests are failing Part of that is my fault, I didn't explain the quirks with member function definitions. linux_x86_64 and amigaos-m68k builds use GCC6. This version...

> The getttext comment states it's used in 3 places: charpanel.cpp line 166, idemdat.cpp lines 53 Gold (currency) https://github.com/diasurgical/devilutionX/blob/9536927301dafd33008bef6b4d5b5131541db5bc/Source/itemdat.cpp#L53 https://github.com/diasurgical/devilutionX/blob/9536927301dafd33008bef6b4d5b5131541db5bc/Source/panels/charpanel.cpp#L166 > idemdat.cpp 235 Gold (quality) https://github.com/diasurgical/devilutionX/blob/9536927301dafd33008bef6b4d5b5131541db5bc/Source/itemdat.cpp#L235

In `LoadGame()` (loadsave.cpp:1751) loading a non-town save file expects exactly 32 light indexes/IDs followed by a max of 32 chunks of data representing each light. This will need to have...

> Draft because: Untested. See also PR #3122 When you're ready you can use the Ready for review button that appears in the workflow status area:  The mark as...

Did you have some more commits you intended to push? You've marked comments as resolved but there's no change to the source visible yet.

I think so, looks like UWP uses WinRT or is a layer on top in some fashion.