Add helpers to anim info
- Added helpers to animationinfo (improves readability of it's usage in the code)
added
triggerFrame - clean all clang-tidy remarks in animationinfo in the process (access/ case style / casts)
review remarks: animationinfo.h <- here are vast majority of changes, but mainly access/sort/case style + added helpers the rest of the code is derivates of these changes.
other change in the rest of the code is support for triggerFrame (load/save/monster/player).
somebody stop me just wanted to squelch some clang-tidy warnings:
- misc-non-private-member-variables-in-classes
- invalid case style for member
Can you please rewrite the history to squash related commits and put the clang-tidy changes first? Having 14 commits with very similar names doing partial applications of a change makes it hard to review.
Can you please rewrite the history to squash related commits and put the clang-tidy changes first? Having 14 commits with very similar names doing partial applications of a change makes it hard to review.
I think that since most changes are straigthforward like case style change, it is best to view as final work together. I could squash them all together. Reversing history would be meaning I had to write things I replaced by helpers in a way I did not write it here.
Oh, the only place I moved things around is header file of animationinfo. The rest are replace strings in lines and simple additions. Or really simple one line movings in one or two switch cases.
Ye, I checked again. It is best to inspect the header 1st. Like all those getters/setters/helpers. So if header is fine, the rest are derivatives of its changes. Plus added handling for triggerFrame in the code.
Squashed and rebased on latest changed master.