diasurgical
Localization String overlap/omission: item prefix for Gold
The project only has localization string 417 for the word Gold, and it's used in many contexes.
It is also used for the prefix for "golden" which is a different string for greek and other languages with gender forms. So, once a "ring of gold" dropped in our QA games this omission became apparent.
Please add prefix string "Gold" for items, (tagged as a prefix like others are in it's group)
localization string 417
I think you might be thinking this is some sort of ID, but I think it's a line number where the string appears, could you let us know what file that is for?
Regarding all the comments about genders in various issues. Gettext does not have support for language genders. We intent to add lua support and allow translators to hook in to the name generation for items so that it can be fully customized.
localization string 417
I think you might be thinking this is some sort of ID, but I think it's a line number where the string appears, could you let us know what file that is for?
Poe Edit, states "ID" in the column, but yes it may be a line number. it's in my greek localization file.
The getttext comment states it's used in 3 places: idemdat.cpp lines 53 and 235 and in charpanel.cpp line 166.
Regarding all the comments about genders in various issues. Gettext does not have support for language genders. We intent to add lua support and allow translators to hook in to the name generation for items so that it can be fully customized.
To be fair, I haven't found anything else. and it looks like this is IT.
I'm near 78% done, only quests and gossip text is left, but that is just narrative.
Poe Edit, states "ID" in the column, but yes it may be a line number.
A picture is worth a thousand words
The getttext comment states it's used in 3 places: charpanel.cpp line 166, idemdat.cpp lines 53
Gold (currency) https://github.com/diasurgical/devilutionX/blob/9536927301dafd33008bef6b4d5b5131541db5bc/Source/itemdat.cpp#L53 https://github.com/diasurgical/devilutionX/blob/9536927301dafd33008bef6b4d5b5131541db5bc/Source/panels/charpanel.cpp#L166
idemdat.cpp 235
Gold (quality) https://github.com/diasurgical/devilutionX/blob/9536927301dafd33008bef6b4d5b5131541db5bc/Source/itemdat.cpp#L235
@xGnoSiSx i looked but I have no idea where you got that ID from, I assumed you meant Poedit when you said Poe Edit, but maybe that is something else?
@Ajenbo yes sorry bad typos all around from my end, I do use poedit...
As @ephphatha linked the source, the localization string for +% chance to hit on items (21 - 30 %) at itemdat.cpp 235 must be split up into something else. Because the word for gold as a quality of an item has to be a different string than gold as currency.
So, the correct version, for translation purposes for greek and other languages should be:
gold_currency = "Χρυσός"
gold_quality = "του Χρυσού" or similarly "απο Χρυσό" (translation: "of gold" or similarly "made from gold")
It looks like it's localization string count. Because it doesn't match to any line munber. Poedit just counts the number of entries for a file?
