Eoghan Murray

Results 273 comments of Eoghan Murray

I'm using BitWig 3.2 I was not seeing those nice bespoke controls from your screenshot though! Checking again, I pressed the 'Show Plug-In Window' icon, but it's impossible to make...

Yes, it still happens after restart! The only thing I can think of is that I've got a high DPI screen. Oh well, it could be something to do with...

Sorry I don't understand the failing test output or whether it relates to the changes I've made?

Yep, feel free to just change the user visible output :+1:

Thanks @Fogapod I've made the minimal set of changes to the docs and added a test case. I've raised a similar issue in redis-py to see if there are any...

Just now realise that there is some similar prior work on this: https://github.com/predis/predis/issues/149 I think the hash slot checks also satisfy those conditions: - IF the key contains a {...

(In earlier debugging I also couldn't find a timeout parameter that I could supply in order to produce a stack trace to figure out where the hanging was happening)

If there was a possibility of a remapping config, there's a few other instances of calls to `cluster_nodes` that would have to get the same treatment, e.g. https://github.com/NoneGG/aredis/blob/master/aredis/commands/iter.py#L84

This has gotten a review and some refinement over at https://github.com/talkiq/yaaredis/pull/7 I'll try to update here once that process is complete.

Thanks for alerting me on this! The `data-style` solution wouldn't work as the style attribute is special and has an API associated with it (old.style.getPropertyValue). The `this.doc.createElement('span')` bit is just...