Eoghan Murray

Results 273 comments of Eoghan Murray

Here's another motivating example: ``` { "adds": [ { "parentId": 1220, "nextId": null, "node": { "type": 2, "tagName": "div", "attributes": { "class": "fb-customerchat fb_invisible_flow fb_iframe_widget",...[snip].. }, "childNodes": [], "id": 1223...

There's also the idea of having throttling on mutations so that we can pick up this kind of stuff across multiple mutations that happen within a very short period of...

We are already simulating changing CSS state upon mouse hover, so I'd consider this proposal to be in the same vein. Actually I don't think I understand your comment at...

Ah okay; ya I can't see any DOM changes when a menu is clicked. Are you saying it's possible to track shadow-dom changes? I guess it's related to this one:...

How would you replay the changes to the shadow dom though?

@Juice10 I hadn't envisioned that usecase and haven't tested that. I just came across this since reading your comment: https://github.com/rrweb-io/rrweb-snapshot/pull/10 Maybe that is unrelated? Do you have a chance to...

The electron (https://www.electronjs.org/ ?) application of rrweb is definitely not on my radar, I was only thinking of the web; so I guess a run through it's paces would be...

Should this be a configuration option for it to be accepted?

Does https://github.com/rrweb-io/rrweb/pull/481 change it so that it starts with the top level document, or is it just in whatever document that rrweb is initiated? https://github.com/rrweb-io/rrweb/blob/1dd91f0737dc326560fec4bccb0264623777103f/src/record/index.ts#L439-L442 I think the latter is...