rename 'remove' to 'exclude' when referring to candidate list

[eoghanmurray]

The word 'remove' is a synonym of 'delete', and nearly caused me a heart attack when I saw that it was apparently 'removing' the vast proportion of the input files (whereas the message meant that the vast proportion of input files were being removed from the files that are going to be further processed!)

• I've changed the term from 'remove' to 'exclude'
• the idea of there being a 'list' of files for consideration is really an internal implementation detail and shouldn't need to be exposed to the user.
• Even in the README, the word remove was also being used as a synonym for delete: "I can now remove the one I consider a duplicate by hand if I want to"
• the -removeidentinode option has been renamed to -excludeidentinode. Have left in support for previous option for backwards compatibility; hopefully I've done that right

[eoghanmurray]

Sorry I don't understand the failing test output or whether it relates to the changes I've made?

[pauldreik]

Sorry for the late reply. I understand that the word remove can be upsetting :-)

Internally, remove is ok to use in some places, as it has a well defined meaning in C++.

I will have to think about which parts of this PR I want to adopt. Thanks for the writeup and patch!

[eoghanmurray]

Yep, feel free to just change the user visible output :+1: