Ed Maste
Ed Maste
I understand the value of having it in homebrew, I just wasn't aware of anyone using kyua outside of FreeBSD. Upstream is https://github.com/freebsd/kyua. When we incorporate software into the FreeBSD...
ATF 0.22 was just released -- https://github.com/freebsd/atf/releases/tag/atf-0.22 -- and I hope that this is next on @ngie-eign's list.
Where is the `ARRAY_SIZE` definition coming from? See also `nitems()` in sys/param.h
We currently have `LD_FATAL_WARNINGS=no` in: - lib/libbsnmp/libbsnmp/Makefile - usr.sbin/nmtree/Makefile The second is curious, if nothing handled it in bsd.prog.mk anyway. It was added in c4bd82d701879
What are the warnings we get with amd64-gcc12?
CC @delphij
> So the only real "gotcha" is making sure that the syscalls.master used is from the oldest supported FreeBSD, to avoid using syscalls from the future. Yes, it's unfortunate that...
Eliminating the double negative LGTM, will look at the other change when I have a moment
Typically we don't use a full path in the commit subject - e.g., it could be just `bhyve: Use C99 flexible array instead of GNU extension`. https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message hints at this...
I prefer the reporting that @kprovost suggested in the FreeBSD review. "7/7 passed (and 3 were skipped)" is more immediately obvious to me than "7/10 passed (the three that did...