Ed Maste

> you mean I should add PORTREVISION= 1 now Yes. This is needed so that the pkg has a new version and will get updated. You can make the change...

After more thought I think this is fine w/o a sysctl

Generally looks good. For thr_printf.c we could perhaps introduce `nonstring` or use `{ '0', '1', ...`. I see there have been a few recent commits for `nonstring` but I don't...

CC @asomers

Some of these are not expected to produce identical results -- CPUTYPE, Clang version, optimization options. We should be reproducible with changes to locale, parallel builds, uid, fs type, perhaps...

Yes, enabling debug options will certainly produce different results. (Not just debug info, but WITNESS, INVARIANTS etc.)

I'll comment on other topics later, but specifically with respect to intermediate artifacts (object files, etc.) there's not much value in comparing them vs. the effort of doing so. The...

By a similar argument we don't really need to test reproducibility with only one change, at least for most variables -- there is little nonreproducibility, so we can just do...

9962e195d029f049a53e87a7635ea1ca23a43a34 added a call to intel_vblank_evade() within preempt_disable, which calls schedule_timeout() (and thus mi_switch()); testing this: ``` diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c index 52f5251312..12461b7f0a 100644 --- a/drivers/gpu/drm/i915/display/intel_vblank.c +++ b/drivers/gpu/drm/i915/display/intel_vblank.c @@ -684,12...

With that change we move on to this panic: ``` [126.355346] panic: critical_exit: td_critnest == 0 [126.403042] cpuid = 5 [126.417152] time = 1757357369 [126.431235] KDB: stack backtrace: [126.445547] db_trace_self_wrapper()...