freebsd
Use nitems()
Where is the ARRAY_SIZE definition coming from? See also nitems() in sys/param.h
@ElyesH would you mind amending your commit messages with
Pull Request: https://github.com/freebsd/freebsd-src/pull/888
?
@ElyesH would you mind amending your commit messages with
Pull Request: https://github.com/freebsd/freebsd-src/pull/888?
Hi,
Sorry for the question, But please , what you mean by pull request ? I'm using git and git pull https://github.com/freebsd/freebsd-src/pull/888 won't work here
When you look at the actual commits that landed from your last Pull Request:
https://github.com/freebsd/freebsd-src/commit/e5f905c72a33007aac3b2061d6404b1d962cd5ba
for instance, you don't see a reference to the Pull Request. That's why I'm asking if you could include a reference to this Pull Request in all its commit messages.
This needs a rebase, and it needs to remove the sys/types.h and sys/cdefs.h when we add sys/param.h. It's on the edge of 'useful enough' but if you do that, and remove the 'Pull Request: ' lines from the commit messages, then I'll go ahead and commit it. as far as I can tell, there's no semantic change.
I may try to land the ones w/o comments and that don't conflict to reduce the rebase effort / hassle.
OK. I've landed what I can. I'm closing this. Under the policy when it was submitted, it was OK, but the new policy is to only accept changes that can enumerate a specific problem, so I'm going to close it, but it's unlikely we'd accept the update. I did make the changes I wanted and that markj highlighted since this has taken so long, but generally I don't like to tweak the pull requests...