Thomas Rittson
Thomas Rittson
I'll test this on Safari (as requested), plus a few other major browsers. I'll take another, closer look at the diff, and I've also asked for a second set of...
I've given this a quick test on Safari (using my Codepen, plus quick regression test on Facebook, Google and Amazon login pages). As expected, it fills open ShadowDOMs but not...
CI branch has been updated, I'll get a final review + quick test in on this next week.
Looks great, thanks again @RafaelKr! I'll pass it on to our QA team for testing.
> Support objects that decrypt differently attachments seems to have some custom logic, and there has been some discussion around potentially having an EncObject which contains a json blob instead...
I'm still a little unsure what the end state of `CryptoService` and `EncryptService` is. The duplicated interfaces between them are starting to get messy. iirc, the last we discussed was...
Removing myself from reviewers on the understanding this will be done in the SDK instead.
This may be related to how we save the Electron window position. There should be some way of checking whether the saved position is out of bounds and adjusting accordingly.
This also occurs when calling `updateValueAndValidity()` directly on the FormControl. Here's another minimal repro: https://plnkr.co/edit/5I0zDkCnn0ttg0qp?open=lib%2Fapp.ts&deferRun=1. I would think this is a bug, not a feature request. The documentation for `updateValueAndValidity`...
Converting to draft until #4032 is merged as that will cause conflicts.