Thomas Rittson
Thomas Rittson
Converting to draft while I clarify requirements and potentially add additional flagging.
@shane-melton I've made further changes after our discussions and going round in circles a bit. The problem is that the individual vault should only evaluate individual permissions, not admin permissions....
I'm going to wait until #9100 is merged, as that will probably be merged first and will cause conflicts.
I had to spend a bit more time on this, here's the summary. In https://github.com/bitwarden/clients/pull/8818/commits/5e66416c13dff18d61d09a2431cec4609140b1c1 I removed the `@bitwarden/bit-common` path mapping from `apps/web`, because the web vault is OSS code....
@bitwarden/team-platform-dev should own the layout components, see #8814. I've requested their review, please treat them as a code owner (i.e. don't merge without their approval).
Good point. I looked around before starting work but couldn't see any other ticket or PR for it. @Hinton would you like to create a PR for your changes instead?
Discussed with @Hinton, we'll revisit this in January (after the break) and work on a fix that accommodates older Safari versions.
We've discussed that option internally, it's tempting but we decided to err on the side of backwards compatibility for those users, at least for a little while longer. No updates...
I'm handing this ticket to the appropriate team to work on. I'm not sure that parsing the UserAgent string is a good idea, and my focus is on other work...
Good point about the test case - there's actually already a test case for this, it was just giving a false negative. To cover this, we need to assert the...