Thomas Rittson
Thomas Rittson
I personally prefer silently pruning empty URIs upon save. There's no use case for saving an empty URI, so no need to bother the user with an error message in...
Hi @qinxs, I'll bump our internal tracking of this issue for visibility, however it's not currently prioritised for work. PRs are welcome though, please see my [previous comment](https://github.com/bitwarden/clients/issues/1208#issuecomment-1244727529).
@MGibson1 Can you please review what I've done so far before I spend time polishing? I updated the PR description above to explain it all. Thanks!
@MGibson1 > I don't quite understand what the expansion of automapper is doing. Is the intent to get rid of a bunch of boilerplate model mapping? Yes, exactly. For example,...
Actioned some feedback and responded to others, requesting another review just to make sure you see the updates :)
Just working through design feedback on this one.
I've updated the PR description with latest changes.
@r-tome as discussed, when you come back to this I think you can do a simple lift-and-shift of the current code into a command, and we can refine it later....
[AC-1637] Sanitize Business and Organization Names from html script injection prior to storing in db
@r-tome last we spoke about this, you were having problems with the encoded value exceeding the max length and then getting truncated in the database. What was the resolution to...
This is pretty old by this point and has never come up again, so I'm leaving it be.