Elijah ben Izzy

Results 285 comments of Elijah ben Izzy

Also this decouples us from `circleci` which is nice if we want to change up CI tooling. I'm in favor 👍

Need to add tests/figure out what to test. Hopefully this demonstrates the issue. IMO chainmap is actually better here -- supporting a lazyconfig is reasonable. That said, I'd prefer the...

Pros of this: 1. It allows lazily evaluated configs 2. Its idiomatic -- types are only as constricted as they need to be (E.G. why does config have to be...

Agreed that both might be nice, and that (1) is pretty clean for most use-cases. (2) could actually be implemented pretty cleanly with `model` (soon to be named `dynamic_node`). You...

Another TODO -- support data quality for dataframes. Some ideas: 1. Add a `output` argument to these, allowing us to extract an item in the dataframe, etc... E.G. anything sliceable...

OK, starting to think about this one. This is *not* something we want yet, but it is something we should plan for. Going to propose the following spec, I think...

Is there any progress on this? The side-effect argument doesn't convince me. One could add a pure_function marker that allows them to run in tandem. Also tests really shouldn't have...

Sorry for the tone! I had not had my coffee yet when I posted. Will post less tone-y in the future -- I understand that you folks have thought a...

👍 on this -- would be quite helpful. Could submit a PR at some point but I haven't dug into the code enough yet. That said, I was first looking...

Purely a WIP right now, need to finish implementation then add a ton of tests