Elijah ben Izzy

Results 285 comments of Elijah ben Izzy

Comments from @skrawcz: (originally here): https://github.com/stitchfix/hamilton/pull/199#pullrequestreview-1112603506 I'm concerned about: 1. commit history preservation - wouldn't want to lose some of the "why" for some of the decorators. 2. Any reason...

OK, feedback has suggested we keep it and invest. Thoughts about this? ```python import functools import pandas as pd from hamilton.function_modifiers import does def _sum_series(*series: pd.Series) -> pd.Series: return functools.reduce(series,...

Merged, will close when released

Released as of `1.11.0` https://github.com/stitchfix/hamilton/releases

Seems reasonable -- want to get the naming right though so its clear what its doing. I'd prefer to make this simpler though -- is there a way to just...

@ropeladder OK, awesome, this makes a lot of sense to me now. Specifically, this is doing *both* an `extract_columns` and a `parameterize` operation at once, all specified by a dataframe....

@skrawcz haven't had a chance to look yet. @ropeladder would love to sync up -- happy to provide this as a recipe/think about including in the main framework. If I...

Talked with the folks from selectstar last night -- might be an interesting potential integration: https://www.selectstar.com/

Started working on this -- got a rough POC working but its fairly complicated and wasn't worth my time. What I'd love is doing this on the "intro to hamilton"...