Elijah ben Izzy

Results 285 comments of Elijah ben Izzy

Oh interesting. So: `{'foo' : node('foo_source'), 'bar' : value('bar')}`? Then keep `@parameterize_inputs` and `@parameterize_values`? I don't think `@parameterize_node` would make too much sense... Maybe `@parameterize_sources` and `@parameterize_values` makes sense? Along...

`input` can be namespaced, but agreed we want to steer clear from builtins. IMO: - `@parameterize_sources` and `{'arg' : source('arg_source')}` - `@parameterize_values` and `{'arg' : value('arg_value')}` Are internally consistent, logical,...

OK, so I think I'm going to go with the above: - `@parameterize_sources` and `source(...)` - `@parameterize_values` and `value(...)` IMO its the clearest and most concise - any objections?

So, I think this makes sense. The question is whether you want to do this just on the inventory column, or on a bunch of different columns (E.G. different types...

> Thanks for clarifying my example. I agree that it is a bit verbose but definitely gets the job done. Can I naturally extend this example to use 2 threshold...

@skrawcz yeah, I think so. @latlan1, would love to get a sense of how the new changes to `@parameterize` woudl help you: https://github.com/stitchfix/hamilton/blob/main/decorators.md#parameterize.

Either one could be OK I think. That said, I want to try something like the following, in the driver: ``` sys.modules['pandas'] = modin.pandas ``` So long as its the...

> Not that urgent. Supporting union type hints is more important for now. Awesome, I'll be seeing that across the finish line shortly as Stefan will be out for a...

Hey @wangkev -- rc out! `pip install sf-hamilton==1.10.0rc0`. Happy to fix any bugs, planning on a general release shortly. FYI this has both `Union` and [full parameterization](https://github.com/stitchfix/hamilton/issues/162)!

Hey @latlan1 -- interesting use-case! To dig in more -- `inventory` is a column as well, right? So in the final DAG that gets created, would both `inventory_greater_eq_than__260 ` and...