hamilton icon indicating copy to clipboard operation
hamilton copied to clipboard

Some scaffolding

Open elijahbenizzy opened this issue 3 years ago • 1 comments

[Short description explaining the high-level reason for the pull request]

Changes

Testing

Notes

Checklist

  • [ ] PR has an informative and human-readable title (this will be pulled into the release notes)
  • [ ] Changes are limited to a single goal (no scope creep)
  • [ ] Code can be automatically merged (no conflicts)
  • [ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • [ ] Passes all existing automated tests
  • [ ] Any change in functionality is tested
  • [ ] New functions are documented (with a description, list of inputs, and expected output)
  • [ ] Placeholder code is flagged / future TODOs are captured in comments
  • [ ] Project documentation has been updated if adding/changing functionality.
  • [ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist

Python - local testing

  • [ ] python 3.6
  • [ ] python 3.7

elijahbenizzy avatar Jun 17 '22 22:06 elijahbenizzy

Another TODO -- support data quality for dataframes. Some ideas:

  1. Add a output argument to these, allowing us to extract an item in the dataframe, etc... E.G. anything sliceable
  2. output could also apply to a specific column in extract_columns
  3. Add a schema argument, allowing us to run on a dataframe (E.G. column -> type mapping). Note this is redundant with datatype as well...

elijahbenizzy avatar Jun 20 '22 20:06 elijahbenizzy