hamilton
hamilton copied to clipboard
Some scaffolding
[Short description explaining the high-level reason for the pull request]
Changes
Testing
Notes
Checklist
- [ ] PR has an informative and human-readable title (this will be pulled into the release notes)
- [ ] Changes are limited to a single goal (no scope creep)
- [ ] Code can be automatically merged (no conflicts)
- [ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
- [ ] Passes all existing automated tests
- [ ] Any change in functionality is tested
- [ ] New functions are documented (with a description, list of inputs, and expected output)
- [ ] Placeholder code is flagged / future TODOs are captured in comments
- [ ] Project documentation has been updated if adding/changing functionality.
- [ ] Reviewers requested with the Reviewers tool :arrow_right:
Testing checklist
Python - local testing
- [ ] python 3.6
- [ ] python 3.7
Another TODO -- support data quality for dataframes. Some ideas:
- Add a
outputargument to these, allowing us to extract an item in the dataframe, etc... E.G. anything sliceable outputcould also apply to a specific column in extract_columns- Add a
schemaargument, allowing us to run on a dataframe (E.G. column -> type mapping). Note this is redundant withdatatypeas well...