Eli Bendersky comments

Results 225 comments of


                                            Eli Bendersky

Bug: DOS when iterating over sections

Thanks for the report. PRs to fix this are welcome.

Bug: DOS when iterating over sections

To be clear, `pyelftools` was never designed to be used in security-critical settings. For example, it's not particularly fast (being pure Python and all), and it can be trivially "DOS"-ed...

STB_GNU_UNIQUE support. Patch included

Please submit a pull request

Shouldn't DW_FORM_strp values be strings?

`parse_cstring_from_stream` returns a bytes because that's what we read from the binary file, without encoding. bytes was also convenient in a Python 2/3 split world

examples/dwarf_location_lists.py and examples/dwarf_range_lists.py fail with Jython

Thanks for report. I'm unlikely to find time to debug this in the near future, so pull requests are welcome.

Should `get_string` of `StringTableSection` return string instead of bytes?

Yes, this is a good point. The names (and other "strings") should probably be decoded to Python3 strings. AFAIU, the default DWARF encoding is ascii, unless a special setting exists...

Add API for high-level access to version info

Can you clarify which specific structures and what code in `readelf.py` you are referring to?

Add API for high-level access to version info

Ah, I see. Yeah, that could be a nice feature

Can pyelftools load elf file without section headers?

What do you mean by "error when loading". Can you reproduce the elftools commands exactly? I can do `-h` and `-l` runs on `f_busybox` using `scripts/readelf.py`, for example

Access enums as enums, not strings?

I'd prefer not to do breaking changes at this point. If this can be packaged as a non-breaking change, I will consider accepting a PR when Python 2 officially EOLs.