langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

llms: Add fake package

Open devalexandre opened this issue 1 year ago • 3 comments

PR Checklist

  • [x] Read the Contributing documentation.
  • [x] Read the Code of conduct documentation.
  • [x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [ ] Describes the source of new concepts.
  • [ ] References existing implementations as appropriate.
  • [x] Contains test coverage for new functions.
  • [x] Passes all golangci-lint checks.

devalexandre avatar Jun 27 '24 00:06 devalexandre

You checked " Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).", but in fact it's not clear at all what and why this is doing.

Also, the code is full of Portuguese comments and strings, is this intentional?

eliben avatar Jun 27 '24 14:06 eliben

You checked " Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).", but in fact it's not clear at all what and why this is doing.

Also, the code is full of Portuguese comments and strings, is this intentional?

sorry , I'll update to en and edit the list

devalexandre avatar Jun 27 '24 14:06 devalexandre

I suggest adding a Generate interface to pass in, instead of responses []string.

Then implement a Default Generate to support it. This would allow for better customization and extensibility.

flc1125 avatar Jul 23 '24 00:07 flc1125