Elliotte Rusty Harold
Elliotte Rusty Harold
There are other ways to make sure we build the UI. I agree with @rschlussel that presto-main should not depend on presto-ui.
NaN's a weird one. I'm not sure we should do this. I'm not sure we shouldn't. However, I do notice that the RFC doesn't address the case of null comparisons...
aend a PR. It's how we review.
Tangential note, but setter methods instead of or in addition to builders are really useful in test code like this. I've been seeing a need for these in other test...
Where are you rerunning? We might have tests that flake on the CI not not on our local dev machines.
The modernizer plugin catches the cases where Guava's checkNotNull can be replaced by Objects.requireNonNull, but it's not always a replacement. Objects.requireNonNull doesn't handle format strings and multiple argiuments whereas Guava's...
It varies from call site to call site. In quite a few cases it's not checking an argument at all: ``` ConnectorMetadata metadata = transactions.get(transactionHandle); checkArgument(metadata != null, "no such...
Which connector are you using?
#1 is not really a solution. #2 is a maybe. In the past I've seen these sorts of tools use a generated-sources directory though at the moment, I can't find...
had to look in the maven-compiler-plugin source code but it likely belongs in `${project.build.directory}/generated-sources/`