Elliotte Rusty Harold
Elliotte Rusty Harold
I don't think anyone is working on this. However, reading through this now I confess I don't see a use case for this feature. That is, why does this matter?...
@blacktooth "Since the file descriptor set generation is different for the same .proto schema, it results in different schemas getting generated." What exactly do you mean by *different* here? Are...
For future reference, relevant code seems to be in protobuf/compiler/command_line_interface.cc void CommandLineInterface::GetTransitiveDependencies
Could you copy and paste one of the examples of useless control flow from the generated code here? Thanks.
Interesting. Do you have a complete reproducible test case, ideally as a failing PR here? I don't immediately see how the code corresponds to the report.
Thanks for the additional info. Spec say, "The value_type can be any type except another map." so this should be OK. Assuming I can reproduce this, it's probably a bug.
I agree. This isn't documented in the spec and protoc should generate name mangling as needed to make this work.
Unless someone has fixed this, it should remain active. legitimate bug reports shouldn't be closed because the team is overloaded.
https://developers.google.com/protocol-buffers/docs/reference/javascript-generated#map Why Record instead of Map? (perhaps obvious to a JavaScript developer) but yes, this looks contrary to the spec.
"The main problem is that when the DIsjointRangeDomainHistogram was introduced it was designed as immutable. When folding all of the instances together via the reduce() call at FilterStatsCalculator#L755 it re-creates...