presto
presto copied to clipboard
Move UI to separate module
Description
Moves the UI to its own module which can be built in parallel or excluded entirely from the build in presto-main
.
Fixes #22741
Motivation and Context
Discussed in the TSC meeting on 2024-05-14. The UI doesn't actually depend on anything in presto-main. This also prevents having the yarn build phases generate files into the source directories.
Impact
No public facing changes.
- The UI module can be skipped in the build by passing
-pl '!presto-ui'
to maven.
Test Plan
- built ui module separately and load SPA resources successfully
- built with maven via
./mvnw clean install -pl presto-main -am -DskipTests
and then ran each of the IcebergQueryRunner and HiveQueryRunner to test the UI. Ran a few queries and clicked on all pages to ensure that the UI loaded each page successfully
Contributor checklist
- [x] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
- [x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
- [x] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
- [x] If release notes are required, they follow the release notes guidelines.
- [x] Adequate tests were added if applicable.
- [x] CI passed.
Release Notes
== NO RELEASE NOTE ==