Elliotte Rusty Harold

Results 445 comments of Elliotte Rusty Harold

As described here, I'm no longer sure there is an issue for appengine-plugins-core to resolve. This library makes that information available downstream. It's up to the individual callers to make...

Can this simply be added to the google-api-java-client BOM? https://github.com/chingor13/google-api-java-client/blob/47c51549cc3b5e2890908ebcb5c62ec733f1ed7d/google-api-client-bom/pom.xml

Can you elaborate on this? What problem does this solve? Why this choice of variable name? Thanks.

`getAccount()` is called by `sign`, which throws SigningException but does not catch this RuntimeException! SigningException is also a runtime exception and shouldn't be.

Since this library is pre-1.0 we're allowed to change the API. We should make SigningException (and possibly others) checked since they can fail unexpectedly due to problems external to the...

AppEngineCredential creates its service account when the object is created and does properly throw IOException if this fails. That's probably what we should do here.

serviceAccountEmail is transient: ``` private transient String serviceAccountEmail; ``` so if it's serialized it will be looked up again when needed. Can it have a different value then?

That is a good thing and is why we should make this a checked exception. Everyone now has to handle an unexpected runtime exception. In most cases they're not so...

This library is pre-1.0. We should be able to make this change.

I think we're going to regret that decision, and it is going to cause problems for customers. How significant I don't know, but ignoring failure modes is not a path...