Elliotte Rusty Harold
Elliotte Rusty Harold
I've decided not to mark Xerces optional. Doing so significantly degrades XOM's performance. The JDK bundled is not an adequate replacement. It can still be excluded from the classpath by...
xiaofeng was right. This method shouldn't be here. However now it is and we're stuck with it. I'm not sure if changing the behavior now is likely to break any...
Externally visible support schedule: https://protobuf.dev/support/version-support/
If I'm interpreting this correctly, you want to check generated files into version control? That's a little known antipattern. Do you still need this if you're not checking generated files...
My claim here is that benchmarks should have been done before adding this. It's an unnecessary optimization that makes the code large and more complex.
CI failures look unrelated, possibly flaky. Will rerun: INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestPrestoNativeGeneralQueriesJSON>AbstractTestNativeGeneralQueries.testFiltersAndProjections:205->AbstractTestQueryFramework.assertQuery:149->AbstractTestQueryFramework.assertQuery:154 Execution of 'actual' query failed: SELECT * FROM lineitem WHERE shipinstruct like 'TAKE BACK#%' escape...
Yes, they're just flaky. Ready for review
Is squash and merge enabled on the repo?
JUnit CLI used to print a single dot for each test. GUI test runners commonly show a growing a colored bar, green until the first test fails and then red....
Let's make sure the analytics reporting is fixed before we spend time on this.