Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
> I tried pushing to your branch to add the migration and I am getting this: In GitHub you can (don't have to) allow maintainers to push to your PRs....
Rebased and squashed. I also expanded the commit message a bit to better describe what's going on.
Rebased and fixed `-Stream` to `-stream`.
@Gauravtalreja1 could you take another look?
Naming is one of the hardest parts. No definitive preference in this comment, but responding to one part. > Rename it to `unauthorized`. It will contain all templates that we...
I noticed you created REX/Ansible jobs to retrieve this script, but if you can already log in on a host via SSH then I'd prefer a complete "configure RHSM according...
There's now an RFC discussing this: https://community.theforeman.org/t/rfc-replace-pub-katello-rhsm-consumer-static-script-with-a-template/38494.
@stejskalleos I think the test failures are related
Have you had a look at the test failures?
It works by deriving the `firmware_type` from the `pxe_loader`: https://github.com/theforeman/foreman/blob/7ce3336d67e1b0b825b8a4add92a340c7d2d144b/app/models/concerns/pxe_loader_support.rb#L49-L59 This is then used in the `firmware_mapping`: https://github.com/theforeman/foreman/blob/7ce3336d67e1b0b825b8a4add92a340c7d2d144b/app/models/compute_resources/foreman/model/vmware.rb#L818-L821 And in parsing the arguments this is used to determine the `firmware`:...