Ewoud Kohl van Wijngaarden

Results 1159 comments of Ewoud Kohl van Wijngaarden

No, it's because it tries to assign it to the host model now instead of transforming it to a vsphere api parameter

> concerns before I test, that way we can test it just once and get this in faster once the code looks good. I assure you, you'll see the exact...

Oh yes, I think I misread that. Apologies for that. Perhaps you can modify the PR to actually point to the PR so we can see if the tests would...

@nofaralfasi and I had some discussion and I came up with https://github.com/ekohl/foreman/commit/707162487891fdd9d2d744c5f52a83470c9d0d72 as some possible improvements.

> Before that, we are calling the new_vm method also from here [compute_object](https://github.com/theforeman/foreman/blob/develop/app/models/concerns/orchestration/compute.rb#L37). So if we raise the error from parse_args, the exception will result in breaking the whole page....

Random thought: could it be thin provisioning?

As suggested in https://github.com/puppetlabs/puppet-modulebuilder/pull/79#discussion_r1641286658 I think your first line needs to be recursive: `**` instead of `*`.

Thanks @maximiliankolb for getting this done!

Perhaps a new top level directory is a better place? These kinds of references that aren't part of the docs themselves but still influence the docs

> I am aware of that and different template kinds are requested at different times, which I'm trying to convey in the diagrams: > > * The `*PXE*` templates are...