foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #37606 - Drop old CentOS installation media

Open ekohl opened this issue 1 year ago • 5 comments

The host mirror.centos.org is gone now that CentOS < 9 is EOL. It includes a migration to simplify the name, but doesn't include migrations to remove old entries. That is up to the user because they may have modified them and still use them.

ekohl avatar Jun 27 '24 17:06 ekohl

@ekohl did you want me to look for areas that were missed and test(provide a patch), not sure if you just didn't have time or was there another reason this was in a draft?

chris1984 avatar Aug 05 '24 15:08 chris1984

I tried pushing to your branch to add the migration and I am getting this:

In GitHub you can (don't have to) allow maintainers to push to your PRs. I have that enabled, but since you're not a maintainer and I didn't grant you explicit permissions you get a permission denied.

That's why I suggested to submit a PR against my fork or open a fresh PR. If you'd like to finish the whole effort then I think the latter is easier.

ekohl avatar Aug 14 '24 15:08 ekohl

Rebased and squashed. I also expanded the commit message a bit to better describe what's going on.

ekohl avatar Aug 15 '24 15:08 ekohl

Rebased and fixed -Stream to -stream.

ekohl avatar Oct 22 '24 12:10 ekohl

@Gauravtalreja1 could you take another look?

ekohl avatar Oct 31 '24 11:10 ekohl